scons: Fix up numerous warnings about name shadowing
Review Request #1716 - Created Feb. 13, 2013 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9522:5056621e6632 --------------------------- scons: Fix up numerous warnings about name shadowing This patch address the most important name shadowing warnings (as produced when using gcc/clang with -Wshadow). There are many locations where constructor parameters and function parameters shadow local variables, but these are left unchanged.
All regressions passing (excluding t1000 and eio)
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Actually I think i was too keen removing the line as pc might have changed. I'll add it again and ... | Andreas Hansson | Feb. 13, 2013, 7:12 p.m. | Open |
-
src/arch/alpha/stacktrace.cc (Diff revision 1) -
Seems like this and the next line can be removed as well.
Posted (Feb. 13, 2013, 7:12 p.m.)
-
src/arch/alpha/stacktrace.cc (Diff revision 1) -
Actually I think i was too keen removing the line as pc might have changed. I'll add it again and simply rename it.
Review request changed
Updated (Feb. 13, 2013, 7:21 p.m.)
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+42 -59) |
I'm not going to review all the other code cleanup patches... I trust you on those, ship'em all! Thanks!