kvm: Add basic support for ARM
Review Request #1754 - Created March 7, 2013 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9626:9656a8def9f3 --------------------------- kvm: Add basic support for ARM Architecture specific limitations: * LPAE is currently not supported by gem5. We therefore panic if LPAE is enabled when returning to gem5. * The co-processor based interface to the architected timer is unsupported. We can't support this due to limitations in the KVM API on ARM. * M5 ops are currently not supported. This requires either a kernel hack or a memory mapped device that handles the guest<->m5 interface.
Posted (March 16, 2013, 3:19 p.m.)
Looks good. Two things: - The limitations/issues should be in a comment in the code somewhere, not just in the commit message. - In the spirit of my earlier superficial naming comments: I think ArmKvmCPU is a better name. Generally classes derived from BaseKvmCPU should be named *KvmCPU (like how the derivatives of BaseSimpleCPU are AtomicSimpleCPU and TimingSimpleCPU).