ruby: message buffer node: used Tick in place of Cycles

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9591:a7eb9a3b3041
---------------------------
ruby: message buffer node: used Tick in place of Cycles
The message buffer node used to keep time in terms of Cycles. Since the
sender and the receiver can have different clock periods, storing node
time in cycles requires some conversion. Instead store the time directly
in Ticks.

Testing Done

Issue Summary

Description	From	Last Updated	Status
curTick here instead of clockEdge i think	Andreas Hansson	March 12, 2013, 10:46 a.m.	Resolved

src/mem/ruby/buffers/MessageBuffer.cc (Diff revision 1)

curTick here instead of clockEdge i think

Show all issues

Nilay Vaish March 12, 2013, 10:46 a.m. (March 12, 2013, 10:46 a.m.)
```
Yes, that would work as well. I'll change it.
```

Perhaps we need some more thinking and a design guideline or similar for how to do this. When to use curTick, clockEdge etc.

Nilay Vaish March 14, 2013, 12:46 a.m. (March 14, 2013, 12:46 a.m.)

Maybe. I never thought of using curTick() because ruby was using ruby system's clock
in all places. I simply replaced that with the clockEdge() of the clocked object in 
context. It never crossed my mind that I could have used curTick() as well.

Andreas Hansson March 14, 2013, 12:51 a.m. (March 14, 2013, 12:51 a.m.)

Oh sure, I'm not saying anything is wrong, and I'm happy with the patch as is :-). It merely highlighted the bigger issue.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)