cpu: Remove CpuPort and use MasterPort in the CPU classes
Review Request #1767 - Created March 14, 2013 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9586:e053f062246c --------------------------- cpu: Remove CpuPort and use MasterPort in the CPU classes This patch changes the port in the CPU classes to use MasterPort instead of the derived CpuPort. The functions of the CpuPort are now distributed across the relevant subclasses. The port accessor functions (getInstPort and getDataPort) now return a MasterPort instead of a CpuPort. This simplifies creating derivative CPUs that do not use the CpuPort.
All regressions pass
Posted (March 14, 2013, 3:27 a.m.)
It seems to me that the CpuPort is not serving any purpose at all. Why can the ports derieved from the CpuPort, not be derieved from the MasterPort directly?
Review request changed
Updated (March 14, 2013, 8:37 p.m.)
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+53 -88) |
Ship It!