mem: Introduce a variable for the retrying port
Review Request #1770 - Created March 14, 2013 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9588:babde3e3415c --------------------------- mem: Introduce a variable for the retrying port This patch introduces a variable to keep track of the retrying port instead of relying on it being the front of the retryList. Besides the improvement in readability, this patch is a step towards separating out the two cases where a port is waiting for the bus to be free, and where the forwarding did not succeed and the bus is waiting for a retry to pass on to the original initiator of the transaction. The changes made are currently such that the regressions are not affected. This is ensured by always prioritizing the currently retrying port and putting it back at the front of the retry list.
All regressions pass
Posted (March 19, 2013, 7:31 p.m.)
All you interconnect-savvy people out there, any input on this one and http://reviews.gem5.org/r/1771/ would be appreciated.
Posted (March 25, 2013, 8:09 a.m.)
Seems fine to me. I had been through the patch before as well. Most of the times I don't have enough understanding to really say whether or not the patch is correct.
Ship It!
