scons: Include flags required to link statically with Python
Review Request #1776 - Created March 14, 2013 and submitted
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9586:f7f6bb9b864a --------------------------- scons: Include flags required to link statically with Python Python requires the flags in LINKFORSHARED to be added the linker flags when linking with a statically with Python. Failing to do so typically results in errors from the Python's dynamic module loader at start up. --- Note: We probably only want these flags to apply to the Python libraries. I don't have a good solution for this. We could possibly try to solve the symbol export issue ourselves, but that requires knowledge about the linker. Note 2: Debian Stable and Debian Testing seem to lack Py_ENABLE_SHARED even though the shared library exists.
Tested to compile and run on a machine where only the static library exists. Works with the patch, but not without. Ran the ARM quick regressions on Debian Testing.
Ship It!
LGTM. Could you add some of the description from the patch summary to the comments?
Ship It!
