PacketQueue: Add maxQueueDepth parameter and setter

Information
Submitter:	Joel Hestness
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9587:b989f6228833
---------------------------
PacketQueue: Add maxQueueDepth parameter and setter

The default maximum PacketQueue depth of 100 can cause assertion failures when
using the PacketQueue in a setting when the maximum queue depth may be known to
be greater than 100 (e.g. modeling queuing of outstanding requests to the cache
from aggressive GPU core implementations). Parameterize this max depth and add
a method to set the max depth.

Testing Done

Ship It!

Andreas Hansson March 17, 2013, 5:32 p.m. (March 17, 2013, 5:32 p.m.)

Sorry to cause problems here guys, but I think we need to fix this another way. The queued port is not supposed to be a "free" storage resource. If it runs out, we should rather block the cache.

Overall, I have been thinking about how we can turn the queued port into something that can signal back that it is blocking. It gets a bit tricky as you soon end up removing all the functionality of the queued port and end up with the send/retry style interface.

In short: I don't think we should ship this, and I'm keen to hear what people think is a reasonable way to make the queued port "block" it's MemObject (and start it again without polling).

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)