devices: make more classes derive from BasicPioDevice

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9594:3389e262b2fd
---------------------------
devices: make more classes derive from BasicPioDevice

A couple of devices that have single fixed memory mapped regions
were not derived from BasicPioDevice, when that's exactly
the functionality that BasicPioDevice provides.  This patch
gets rid of a little bit of redundant code by making those
devices actually do so.

Also fixed the weird case of X86ISA::Interrupts, where
the class already did derive from BasicPioDevice but
didn't actually use all the features it could have.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Why not leave it out at this point?	Andreas Hansson	March 25, 2013, 2:45 a.m.	Dropped
I'd always vote for putting this in the initializer list, but I leave it up to you	Andreas Hansson	March 24, 2013, 3:21 a.m.	Open

Ship It!

Some very minor things, for the rest go ahead.

src/dev/Pci.py (Diff revision 1)

Why not leave it out at this point?

Show all issues

Steve Reinhardt March 25, 2013, 2:46 a.m. (March 25, 2013, 2:46 a.m.)

The base class has no default value, so if you don't set it to something here, then you get a runtime error for having a parameter with no value.

src/dev/x86/i82094aa.cc (Diff revision 1)

I'd always vote for putting this in the initializer list, but I leave it up to you

Show all issues

Steve Reinhardt March 25, 2013, 2:46 a.m. (March 25, 2013, 2:46 a.m.)

It's actually a field in the base class (BasePioDevice), not in the class for which this is the constructor.  Really the right thing to do is to add the size as an argument to the BasePioDevice constructor (and have that be the only constructor, and change all the derived classes to use it), but I wasn't feeling quite *that* ambitious.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)