dev: make BasicPioDevice take size in constructor

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9597:6123dff2443b
---------------------------
dev: make BasicPioDevice take size in constructor

Instead of relying on derived classes explicitly assigning
to the BasicPioDevice pioSize field, require them to pass
a size value in to the constructor.

Testing Done

That was quick :-)

Steve Reinhardt March 26, 2013, 1:35 a.m. (March 26, 2013, 1:35 a.m.)

After your comment on the other patch, I looked into it a little more closely, and an emacs macro was able to handle most of the cases pretty well.  Plus little things like this help to give me a sense of accomplishment in a world where sadly I rarely have time to do anything more substantial...

Should we not add a size param to the python class for BasicPioDevice instead?

Steve Reinhardt March 26, 2013, 1:32 a.m. (March 26, 2013, 1:32 a.m.)

The size is generally a fixed feature of the device itself, not something that a user would ever want or need to change, and would break things if they did.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)