Simulation.py: Fix handling of maxtick and take_checkpoints

Information
Submitter:	Joel Hestness
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9632:63da4a862efd
---------------------------
Simulation.py: Fix handling of maxtick and take_checkpoints

m5.simulate(num_ticks) will run the simulated system for num_ticks after the
current tick. Fix calls to m5.simulate in scriptCheckpoints() and
benchCheckpoints() to appropriately handle the maxticks variable.

Testing Done

Tested repeated checkpointing and checkpoint restore with maxtick specified

Ship It!

Andreas Hansson April 7, 2013, 10:11 p.m. (April 7, 2013, 10:11 p.m.)

Joel, for all these patches the official keyword should be "ruby", at least if we want to stick to http://gem5.org/Commit_Access

Andreas Hansson April 7, 2013, 10:13 p.m. (April 7, 2013, 10:13 p.m.)

Correction, for this specific one I guess "config" is the way to go.

Jason Lowe-Power April 8, 2013, 12:06 a.m. (April 8, 2013, 12:06 a.m.)

I just now was looking at your other patch and I see that for the option maxtick the help says help="Stop after T ticks". This is ambiguous as to what the expected behavior is. Can you update the help message in this patch to clarify exactly what the behavior should be.

Andreas Hansson April 8, 2013, 1:18 a.m. (April 8, 2013, 1:18 a.m.)

Agreed, the "Run to" and "Stop after" are both rather ambiguous. It would be good if it was made more clear what is absolute (if anything) and what is relative.

Joel Hestness April 9, 2013, 1:54 a.m. (April 9, 2013, 1:54 a.m.)

This patch does not address the handling of maxtick and maxtime script options, but rather the maxtick local variable handling in Simulation.py (run() function and it's callees). I'll move this discussion over to the maxtick v. maxtime review request and address it there: http://reviews.gem5.org/r/1816/

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)