Implement getdents/getdents64 in user mode plus mmap fix
Review Request #1821 - Created April 10, 2013 and submitted
| Information | |
|---|---|
| Michael Adler | |
| gem5 | |
| Reviewers | |
| Default | |
Two patches for user mode (based on 20130123-gem5-stable-f75ee4849c40): - Implement getdents/getdents64 syscalls in user mode. - Change mmap fixed address request to return an error if the mapping is impossible due to conflict instead of what I believe used to be silent corruption.
getdents is tested for Alpha. I implemented for other ISAs but did not compile. mmap to fixed address is permitted to return an error if the address is unavailable, so the change appears better than before. Workloads appear stable.
Review request changed
Updated (April 10, 2013, 1:15 a.m.)
Status: Re-opened
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Testing Done: |
|
||||||||||||
Groups: |
|
||||||||||||
Added Files: |
Posted (April 11, 2013, 2:05 a.m.)
Would it be possible to upload this as a "proper" diff using the mercurial reviewboard-plugin?
Looks fine to me. Thank you for posting the change. My only concern is that there might be an issue running on a 64 bit host and simulating a 32 bit system or the reverse because the unsigned long that is being passed will be different lengths??