x86: bugfix: lret instruction has to increment the stack pointer
Review Request #1825 - Created April 16, 2013 and submitted
| Information | |
|---|---|
| Christian Menard | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
x86: bugfix: lret instruction has to increment the stack pointer lret does not increment the stack pointer which results in misbehavior. I am not sure if this is the best way to fix this, but it works for me.
Tested with a custom kernel.
Posted (April 17, 2013, 5:37 a.m.)
I am guessing you read some x86 instruction manual to figure this out. Can you mention the manual you read? After reading a code snippet that appears in "AMD64 Architecture Programmer’s Manual Volume 3: General-Purpose and System Instructions", it appears to me that the suggested change may not be required in all the cases that 'ret' instruction needs to handle.
Ship It!
Posted (April 22, 2013, 3:07 p.m.)
Chris, please mark this request as submitted.
