stats: allow printing vectors on a single line

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9742:e6a06a278775
---------------------------
stats: allow printing vectors on a single line
This patch adds a new flag to specify if the data values for a given vector
should be printed in one line in the stats.txt file. The default behavior
will be to print the data in multiple lines. It makes changes to print
functions to enforce this behavior.

Testing Done

Description:

~		Changeset 9680:0c60cb23e10b
	~	Changeset 9680:af90dcb69c0c

		stats: add a flag for printing histograms on a single line
		This patch adds a new flag to specify if the data values for a given
		histogram should be printed in one line in the stats.txt file.
		The default behavior will be to print the data in multiple lines.

Diff:

Revision 2 (+37 -9)

Show changes

	src/base/stats/info.hh
	src/base/stats/text.cc

Testing Done:

	+	Before:
	+
	+	system.monitor.readLatencyHist::samples 3333399 # Read request-response latency
	+	system.monitor.readLatencyHist::mean 20878.092191 # Read request-response latency
	+	system.monitor.readLatencyHist::gmean 19621.155070 # Read request-response latency
	+	system.monitor.readLatencyHist::stdev 15688.085413 # Read request-response latency
	+	system.monitor.readLatencyHist::0-32767 3201881 96.05% 96.05% # Read request-response latency
	+	system.monitor.readLatencyHist::32768-65535 104731 3.14% 99.20% # Read request-response latency
	+	system.monitor.readLatencyHist::65536-98303 5355 0.16% 99.36% # Read request-response latency
	+	system.monitor.readLatencyHist::98304-131071 4826 0.14% 99.50% # Read request-response latency
	+	system.monitor.readLatencyHist::131072-163839 4267 0.13% 99.63% # Read request-response latency
	+	system.monitor.readLatencyHist::163840-196607 3205 0.10% 99.73% # Read request-response latency
	+	system.monitor.readLatencyHist::196608-229375 3236 0.10% 99.82% # Read request-response latency
	+	system.monitor.readLatencyHist::229376-262143 2130 0.06% 99.89% # Read request-response latency
	+	system.monitor.readLatencyHist::262144-294911 1602 0.05% 99.94% # Read request-response latency
	+	system.monitor.readLatencyHist::294912-327679 1620 0.05% 99.98% # Read request-response latency
	+	system.monitor.readLatencyHist::327680-360447 546 0.02% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::360448-393215 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::393216-425983 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::425984-458751 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::458752-491519 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::491520-524287 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::524288-557055 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::557056-589823 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::589824-622591 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::622592-655359 0 0.00% 100.00% # Read request-response latency
	+	system.monitor.readLatencyHist::total 3333399 # Read request-response latency
	+
	+
	+
	+
	+
	+	After:
	+
	+	system.monitor.readLatencyHist::samples 3333399 # Read request-response latency
	+	system.monitor.readLatencyHist::mean 20878.092191 # Read request-response latency
	+	system.monitor.readLatencyHist::gmean 19621.155070 # Read request-response latency
	+	system.monitor.readLatencyHist::stdev 15688.085413 # Read request-response latency
	+	system.monitor.readLatencyHist::lower_bound 0 # Read request-response latency
	+	system.monitor.readLatencyHist::upper_bound 655359 # Read request-response latency
	+	system.monitor.readLatencyHist::bucket_size 32768 # Read request-response latency
	+	system.monitor.readLatencyHist::data 3201881 104731 5355 4826 4267 3205 3236 2130 1602 1620 546 0 0 0 0 0 0 0 0 0
	+	system.monitor.readLatencyHist::total 3333399 # Read request-response latency

Summary:

-	stats: add a flag for printing histograms on a single line
+	stats: allow printing vectors and histograms on a single line

Description:

~		Changeset 9680:af90dcb69c0c
	~	Changeset 9704:1913012dc60b

~		stats: add a flag for printing histograms on a single line
~		This patch adds a new flag to specify if the data values for a given
~		histogram should be printed in one line in the stats.txt file.
~		The default behavior will be to print the data in multiple lines.
	~	stats: allow printing vectors and histograms on a single line
	~	This patch adds a new flag to specify if the data values for a given vector
	~	or a histogram should be printed in one line in the stats.txt file. The
	~	default behavior will be to print the data in multiple lines. It makes
	+	changes to print functions to enforce this behavior.

Diff:

Revision 3 (+69 -25)

Show changes

	src/base/stats/info.hh
	src/base/stats/text.cc

Testing Done:

-		Before:
-
-		system.monitor.readLatencyHist::samples 3333399 # Read request-response latency
-		system.monitor.readLatencyHist::mean 20878.092191 # Read request-response latency
-		system.monitor.readLatencyHist::gmean 19621.155070 # Read request-response latency
-		system.monitor.readLatencyHist::stdev 15688.085413 # Read request-response latency
-		system.monitor.readLatencyHist::0-32767 3201881 96.05% 96.05% # Read request-response latency
-		system.monitor.readLatencyHist::32768-65535 104731 3.14% 99.20% # Read request-response latency
-		system.monitor.readLatencyHist::65536-98303 5355 0.16% 99.36% # Read request-response latency
-		system.monitor.readLatencyHist::98304-131071 4826 0.14% 99.50% # Read request-response latency
-		system.monitor.readLatencyHist::131072-163839 4267 0.13% 99.63% # Read request-response latency
-		system.monitor.readLatencyHist::163840-196607 3205 0.10% 99.73% # Read request-response latency
-		system.monitor.readLatencyHist::196608-229375 3236 0.10% 99.82% # Read request-response latency
-		system.monitor.readLatencyHist::229376-262143 2130 0.06% 99.89% # Read request-response latency
-		system.monitor.readLatencyHist::262144-294911 1602 0.05% 99.94% # Read request-response latency
-		system.monitor.readLatencyHist::294912-327679 1620 0.05% 99.98% # Read request-response latency
-		system.monitor.readLatencyHist::327680-360447 546 0.02% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::360448-393215 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::393216-425983 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::425984-458751 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::458752-491519 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::491520-524287 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::524288-557055 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::557056-589823 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::589824-622591 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::622592-655359 0 0.00% 100.00% # Read request-response latency
-		system.monitor.readLatencyHist::total 3333399 # Read request-response latency
-
-
-
-
-
-		After:
-
-		system.monitor.readLatencyHist::samples 3333399 # Read request-response latency
-		system.monitor.readLatencyHist::mean 20878.092191 # Read request-response latency
-		system.monitor.readLatencyHist::gmean 19621.155070 # Read request-response latency
-		system.monitor.readLatencyHist::stdev 15688.085413 # Read request-response latency
-		system.monitor.readLatencyHist::lower_bound 0 # Read request-response latency
-		system.monitor.readLatencyHist::upper_bound 655359 # Read request-response latency
-		system.monitor.readLatencyHist::bucket_size 32768 # Read request-response latency
-		system.monitor.readLatencyHist::data 3201881 104731 5355 4826 4267 3205 3236 2130 1602 1620 546 0 0 0 0 0 0 0 0 0
-		system.monitor.readLatencyHist::total 3333399 # Read request-response latency

I am planning to commit this patch on Monday.

Summary:

-	stats: allow printing vectors and histograms on a single line
+	stats: allow printing vectors on a single line

Description:

~		Changeset 9704:1913012dc60b
	~	Changeset 9742:e6a06a278775

~		stats: allow printing vectors and histograms on a single line
	~	stats: allow printing vectors on a single line
		This patch adds a new flag to specify if the data values for a given vector
~		or a histogram should be printed in one line in the stats.txt file. The
~		default behavior will be to print the data in multiple lines. It makes
~		changes to print functions to enforce this behavior.
	~	should be printed in one line in the stats.txt file. The default behavior
	~	will be to print the data in multiple lines. It makes changes to print
	~	functions to enforce this behavior.

Diff:

Revision 4 (+42 -15)

Show changes

	src/base/stats/info.hh
	src/base/stats/text.cc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 9680:0c60cb23e10b

Changeset 9680:af90dcb69c0c

Diff:

Testing Done:

Summary:

Description:

Changeset 9680:af90dcb69c0c

Changeset 9704:1913012dc60b

Diff:

Testing Done:

Summary:

Description:

Changeset 9704:1913012dc60b

Changeset 9742:e6a06a278775

Diff:

Status: Closed (submitted)