arm: Fix compilation error in m5 utility

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9686:5708a2e568c9
---------------------------
arm: Fix compilation error in m5 utility

Changeset 5ca6098b9560 accidentally broke the m5 utility. This
changeset adds the missing co-processor call used to trigger the
pseudo-op in ARM mode and fixes an alignment issue that caused some
pseudo-ops to leave thumb mode.

Testing Done

Tested tested a couple of different pseudo ops in SE mode. Use both the Thumb version and the ARM version of the library.

Issue Summary

Description	From	Last Updated	Status
Do you want this? What happens in the case of ARM code (not thumb). Isn't the push unaligned?	Ali Saidi	May 12, 2013, 6:27 p.m.	Dropped

util/m5/m5op_arm.S (Diff revision 1)

Do you want this? What happens in the case of ARM code (not thumb). Isn't the push unaligned?

Show all issues

Andreas Sandberg May 12, 2013, 6:27 p.m. (May 12, 2013, 6:27 p.m.)

.align 2 aligns to the next 2^2 boundary, so it should be safe in both ARM and Thumb mode. I'm entirely sure if it's needed, but it's definitely not harmful.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)