mem: Spring cleaning of MSHR and MSHRQueue

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9708:fb9ab7597f23
---------------------------
mem: Spring cleaning of MSHR and MSHRQueue

This patch does some minor tidying up of the MSHR and MSHRQueue. The
clean up started as part of some ad-hoc tracing and debugging, but
seems worthwhile enough to go in as a separate patch.

The highlights of the changes are reduced scoping (private) members
where possible, avoiding redundant new/delete, and constructor
initialisation to please static code analyzers.

Testing Done

All regressions pass

Issue Summary

Description	From	Last Updated	Status
Can you comment on how this swap is performed?	Nilay Vaish	May 9, 2013, 12:54 a.m.	Dropped

src/mem/cache/mshr.cc (Diff revision 1)

Can you comment on how this swap is performed?

Show all issues

Andreas Hansson May 8, 2013, 9:48 p.m. (May 8, 2013, 9:48 p.m.)

You mean add a comment in the code? It's using move semantics (rvalues) and is the default STL swap implementation.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)