mem: Cycles converted to Ticks in atomic cache accesses

Download Diff
View Diff

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9734:6b92a6ec3706
---------------------------
mem: Cycles converted to Ticks in atomic cache accesses

This patch fixes an outstanding issue in the cache timing calculations
where an atomic access returned a time in Cycles, but the port
forwarded it on as if it was in Ticks.

A separate patch will update the regression stats.

Testing Done

All regressions pass after stats updates

Expand All
Collapse All

Andreas, why should the compiler not raise an error on this? Did we not have this
separate class Cycles to prevent such code?

Andreas Hansson June 2, 2013, 2:15 a.m. (June 2, 2013, 2:15 a.m.)

The only way of solving this would be to make Ticks a class rather than a typedef, and make the constructor explicit. At the moment Cycles behave like this, but gcc is kind enough to turn Cycles into Ticks without complaining through casting.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)