mem: Align cache timing to clock edges

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9745:58e6081c3e49
---------------------------
mem: Align cache timing to clock edges

This patch changes the cache timing calculations such that the results
are aligned to clock edges.

Plenty stats change as a results of this patch.

Testing Done

All regressions pass after stats updates

Ship It!

Are we relying on pkt->bus{First,Last}WordDelay to be a multiple of the cache clock period?  Of course that would normally be the case if the cache and bus are on the same clock, and I'm sure there are many things we get wrong if they're not, but it seems to be it would be safer to have those terms inside the call to clockEdge() as well.  Unless there's a good reason that they're not... if so, please enlighten me.

Andreas Hansson June 13, 2013, 1:02 a.m. (June 13, 2013, 1:02 a.m.)

Very valid concerns indeed. The main reason they are not included is that they are expressed in Ticks rather than cycles. We could definitely turn them into cycles and them align them, but for now I'd rather keep it as is.

Steve Reinhardt June 13, 2013, 3:34 a.m. (June 13, 2013, 3:34 a.m.)

That sounds like a good reason for keeping it like it is... thanks for the explanation!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)