mem: Tidy up the bridge with const and additional checks
Review Request #1897 - Created June 4, 2013 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9751:04622dc6f4c9 --------------------------- mem: Tidy up the bridge with const and additional checks This patch does a bit of tidying up in the bridge code, adding const where appropriate and also removing redundant checks and adding a few new ones. There are no changes to the behaviour of any regressions.
All regressions pass
Posted (June 6, 2013, 11:12 p.m.)
-
src/mem/bridge.cc (Diff revision 1) -
I think this code is not required since you assert that retryReq is false.
Posted (June 6, 2013, 11:13 p.m.)
-
src/mem/bridge.cc (Diff revision 1) -
You are changing the behavior here.
Posted (June 6, 2013, 11:17 p.m.)
-
src/mem/bridge.cc (Diff revision 1) -
It's intentional.
-
src/mem/bridge.cc (Diff revision 1) -
True, it's mostly there to make it easy to interpret the code. I'll remove it and add a comment
Review request changed
Updated (June 6, 2013, 11:30 p.m.)
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+53 -51) |