Review Board 2.0.15


ARM: Don't write tracedata in completeAcc as we might hav freed it already

Review Request #191 - Created Aug. 13, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
ARM: Don't write tracedata in completeAcc as we might have freed it already

   

  


 


 

  

  









  
 


  

 


















 

  


 


  



   

   
Gabe Black

   
Posted  (Aug. 13, 2010, 5:31 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/arch/arm/isa/templates/mem.isa
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
These aren't in completeAcc, so the changeset description needs adjusting.

You could move that line before the write since you have the write data by then, but I think write() is already calling setData for you so it's really just not necessary. That means you're probably doubly right to remove it.




  

   

   
    
    
   


  


    


   



  

 


  

 

















 



 

  


 


  



   

   
Ali Saidi

   
Posted  (Aug. 17, 2010, 9:05 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/arch/arm/isa/templates/mem.isa
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
comment adjusted