x86: Add support for FXSAVE, FXSAVE64, FXRSTOR, and FXRSTOR64
Review Request #1918 - Created June 10, 2013 and submitted
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
| gblack | |
Changeset 9760:5c7f9a77bfdd --------------------------- x86: Add support for FXSAVE, FXSAVE64, FXRSTOR, and FXRSTOR64
Quick regressions pass. Minor stat differences in full regressions (to be expected since some instructions aren't no-ops anymore). Solves a bug triggered by switching between a simulated CPU that tries to save the x87 state and a virtualized CPU that restores the state (which is completely bogus unless FXSAVE is implemented).
Review request changed
Updated (June 12, 2013, 9:26 p.m.)
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+247 -15) |
Posted (July 13, 2013, 12:09 p.m.)
-
src/arch/x86/utility.hh (Diff revision 2) -
These functions aren't quite as symmetric as they appear to be. Seems like the type of the arg to convX87TagsToXTags should match the return type of convX87XTagsToTags. Also, should the second function be named convXTagsToX87Tags?
-
src/arch/x86/utility.cc (Diff revision 2) -
Can you document what's going on here a little bit?