ruby: fix slicc compiler to complain about duplicate symbols

Information
Submitter:	Lena Olson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9756:4793fa5955e0
---------------------------
ruby: fix slicc compiler to complain about duplicate symbols

Previously, .sm files were allowed to use the same name for a type and a
variable. This is unnecessarily confusing and has some bad side effects, like
not being able to declare later variables in the same scope with the same type.
This causes the compiler to complain and die on things like Address Address.

Testing Done

util/regress --builds="ALPHA_MOESI_hammer,ALPHA_MESI_CMP_directory,ALPHA_MOESI_CMP_directory,ALPHA_MOESI_CMP_token,X86_MESI_CMP_directory" --compile-variants="debug" after application of Changeset 9756:8956d858a9e6 (review request 1921).

Issue Summary

Description	From	Last Updated	Status
I think all changes to this file should be merged with the other patch.	Nilay Vaish	June 18, 2013, 11:51 a.m.	Resolved
If I understand this correctly, what you are saying that only frame 0 needs to be checked. Why is not ...	Nilay Vaish	June 18, 2013, 11:51 a.m.	Resolved
It seems like this statement will allow you to override an earlier declared type with a newly declared type. Is ...	Nilay Vaish	June 18, 2013, 11:52 a.m.	Dropped

src/mem/protocol/MOESI_CMP_token-L1cache.sm (Diff revision 1)

I think all changes to this file should be merged with the other patch.

Show all issues

src/mem/slicc/symbols/SymbolTable.py (Diff revision 1)

If I understand this correctly, what you are saying that only frame 0 needs
to be checked. Why is not possible that other frames have a symbol the 'id'
of which clashes with the 'id' you just got?

Show all issues

Lena Olson June 18, 2013, 11:52 a.m. (June 18, 2013, 11:52 a.m.)
```
Fixed to check all frames.
```

src/mem/slicc/symbols/SymbolTable.py (Diff revision 1)

It seems like this statement will allow you to override an earlier declared 
type with a newly declared type. Is this intentional?

Show all issues

Lena Olson June 18, 2013, 11:52 a.m. (June 18, 2013, 11:52 a.m.)

Description:

~		Changeset 9756:f4ebb213bbb4
	~	Changeset 9756:4793fa5955e0

		ruby: fix slicc compiler to complain about duplicate symbols

		Previously, .sm files were allowed to use the same name for a type and a
		variable. This is unnecessarily confusing and has some bad side effects, like
		not being able to declare later variables in the same scope with the same type.
		This causes the compiler to complain and die on things like Address Address.

Diff:

Revision 2 (+5)

Show changes

src/mem/slicc/symbols/SymbolTable.py

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9756:f4ebb213bbb4

Changeset 9756:4793fa5955e0

Diff:

Status: Closed (submitted)