Review Board 2.0.15


MEM: Make CLREX a first class request operation and clear locks in caches when it in received

Review Request #193 - Created Aug. 13, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
MEM: Make CLREX a first class request operation and clear locks in caches when it in received

   

  


 


 

  

  









  
 


  

 


















 

  


 


  



   

   
Gabe Black

   
Posted  (Aug. 13, 2010, 5:37 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/mem/cache/tags/iic.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
It's best to avoid whitespace only changes, I suppose unless you're fixing a style issue.




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/mem/request.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
This name and comment is too ARM centric. A better name might be CLEAR_LOCK.




  

   

   
    
    
   


  


    


   



  

 


  

 

















 



 

  


 


  



   

   
Nathan Binkert

   
Posted  (Aug. 19, 2010, 3:15 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/arch/arm/tlb.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
You added this in a recent change.  Perhaps it is too far back to fold, but if it's easy, you should probably do this.