Review Board 2.0.15


ARM: Clean up flattening for SPSR adding

Review Request #195 - Created Aug. 13, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ARM: Clean up flattening for SPSR adding

   
Posted (Aug. 13, 2010, 5:40 p.m.)



  
src/arch/arm/isa.hh (Diff revision 1)
 
 
This is doing extra work for all miscregs when only the SPSR is affected. This should be a function just for picking the right SPSR index and only called when the SPSR is accessed, basically just exporting the switch statement in the original code into a function.
Posted (Aug. 17, 2010, 9:11 a.m.)



  
src/arch/arm/isa.hh (Diff revision 1)
 
 
Changed this to only call flattenMiscIndex if SPSR, however I imagine it's a wash since this is being inlined in the function and the first thing in does is the check.