cpu: accurately count idle cycles for simple cpu
Review Request #1953 - Created July 17, 2013 and submitted
| Information | |
|---|---|
| Lena Olson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9811:d0db3e1dab40 --------------------------- cpu: accurately count idle cycles for simple cpu Added a couple missing updates to the notIdleFraction stat. Without these, it sometimes gives a (not) idle fraction that is greater than 1 or less than 0.
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Why the ++ and -- when all we want is 1 and 0. I'd suggest notIdleFraction = 0 and notIdleFraction ... | Andreas Hansson | Aug. 6, 2013, 4:49 a.m. | Open |
Ship It!
Posted (Aug. 6, 2013, 4:49 a.m.)
-
src/cpu/simple/atomic.cc (Diff revision 1) -
Why the ++ and -- when all we want is 1 and 0. I'd suggest notIdleFraction = 0 and notIdleFraction = 1 where ever it says -- and ++ at the moment.
Review request changed
Updated (Aug. 7, 2013, 1:24 p.m.)
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+3081 -31978) |
Review request changed
Updated (Aug. 7, 2013, 1:41 p.m.)
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+10 -6) |
Ship It!