arm: use -march when compiling m5op_arm.S

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9818:42d960aece45
---------------------------
arm: use -march when compiling m5op_arm.S

Using arm-linux-gnueabi-gcc 4.7.3-1ubuntu1 on Ubuntu 13.04 to compiled
the m5 binary yields the error:

m5op_arm.S: Assembler messages:
m5op_arm.S:85: Error: selected processor does not support ARM mode `bxj lr'

For each of of the SIMPLE_OPs. Apparently, this compiler doesn't like the
interworking of these code types for the default arch. Adding -march=armv7-a
makes it compile. Another alternative that I found to work is replacing the
bxj lr instruction with mov pc, lr, but I don't know how that affects the
KVM stuff and if bxj is needed.

Testing Done

Issue Summary

Description	From	Last Updated	Status
extra white space	Ali Saidi	Aug. 6, 2013, 12:22 p.m.	Resolved

Hi Tony,

Thanks for the patch. I ran into an issue where the bxj broke running on some systems (I think with thumb), so I've actually got a patch that reverts it I was thinking about posting. I don't know if you're run into this problem or it was something I did. Anyway, I'm happy with this change, but I just wanted to know if the resulting code was working for you even with it.

Ali

Tony Gutierrez Aug. 6, 2013, 12:22 p.m. (Aug. 6, 2013, 12:22 p.m.)

I only did a simple test where I called /sbin/m5 dumpstats and then /sbin/m5 exit from the command line manually (this was in atomic mode with no caches using the AEL image and 3.3 PCIE kernel). I had 2 stats dumps and it exited fine.

util/m5/Makefile.arm (Diff revision 1)

extra white space

Show all issues

Tony Gutierrez Aug. 6, 2013, 12:22 p.m. (Aug. 6, 2013, 12:22 p.m.)
```
The patch is getting rid of that white space.
```

Tony Gutierrez Aug. 14, 2013, 6:08 a.m. (Aug. 14, 2013, 6:08 a.m.)

Been using this with PARSEC (was compiling libm5 into PARSEC, the reason I came across this problem) without any problems. Anyone else have any thoughts, or should I ship this?

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)