cpu: fix bug when TrafficGen deschedules event

Information
Submitter:	Xiangyu Dong
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9845:703c5503aa97
---------------------------
cpu: fix bug when TrafficGen deschedules event

Need to check if an event is scheduled or not before deschedule it during drain

Testing Done

When does this cause a problem?

Xiangyu Dong Aug. 19, 2013, 10:13 a.m. (Aug. 19, 2013, 10:13 a.m.)
```
when switching cpu types, for example functional-->timing
```

Andreas Hansson Aug. 22, 2013, 4:44 a.m. (Aug. 22, 2013, 4:44 a.m.)

I see the point. If in atomic, then the updateEvent is never scheduled.

I'd rather change the drain code to check if updateEvent.scheduled as a separate if block before the retryPkt == NULL. That way it's more clear that the first if-statement is for the case where we come from atomic. It would be good to also add a comment stating this.

Description:

~		Changeset 9824:ac410523ee99
	~	Changeset 9845:703c5503aa97

		cpu: fix bug when TrafficGen deschedules event

		Need to check if an event is scheduled or not before deschedule it during drain

Diff:

Revision 2 (+5)

Show changes

src/cpu/testers/traffic_gen/traffic_gen.cc

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 9824:ac410523ee99

Changeset 9845:703c5503aa97

Diff:

Status: Closed (submitted)