cpu: clean up architectural register classification

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9846:76e56335fbfe
---------------------------
cpu: clean up architectural register classification

Move from a poorly documented scheme where the mapping
of unified architectural register indices to register
classes is hardcoded all over to one where there's an
enum for the register classes and a function that
encapsulates the mapping.

Testing Done

Issue Summary

Description	From	Last Updated	Status
clang static analysis will complain on this last comma	Andreas Hansson	Aug. 26, 2013, 6:13 p.m.	Resolved
Worth putting in a doxy file?	Andreas Hansson	Aug. 26, 2013, 6:25 p.m.	Dropped
regIdxToClass?	Andreas Hansson	Aug. 26, 2013, 6:24 p.m.	Resolved
NULL please, once again, the static analysis will flag it	Andreas Hansson	Aug. 26, 2013, 6:24 p.m.	Resolved
the trailing semicolon should not be there...I think	Andreas Hansson	Aug. 26, 2013, 6:24 p.m.	Dropped

src/cpu/reg_class.hh (Diff revision 1)

clang static analysis will complain on this last comma

Show all issues

src/cpu/reg_class.hh (Diff revision 1)

Worth putting in a doxy file?

Show all issues

Steve Reinhardt Aug. 26, 2013, 6:27 p.m. (Aug. 26, 2013, 6:27 p.m.)

What's the advantage of a doxy file vs. a wiki page?  I'm not opposed, but don't see the value.  In any case, I'd prefer to take this discussion off the critical path.

Andreas Hansson Aug. 27, 2013, 12:42 a.m. (Aug. 27, 2013, 12:42 a.m.)

The doxy file can refer to other bits and pieces in the code and use cross references. I was not necessarily thinking one or the other. Anyhow, it's up to you.

src/cpu/reg_class.hh (Diff revision 1)

regIdxToClass?

Show all issues

src/cpu/reg_class.hh (Diff revision 1)

NULL please, once again, the static analysis will flag it

Show all issues

src/cpu/reg_class.cc (Diff revision 1)

the trailing semicolon should not be there...I think

Show all issues

Steve Reinhardt Aug. 26, 2013, 6:27 p.m. (Aug. 26, 2013, 6:27 p.m.)

It's a statement, and still needs a semicolon to terminate it.  I tried, gcc complains without it.

Andreas Hansson Aug. 27, 2013, 12:42 a.m. (Aug. 27, 2013, 12:42 a.m.)
```
I stand corrected
```

Some very minor things. For the rest it looks sensible to me.

Description:

~		Changeset 9844:7983be7501e7
	~	Changeset 9846:76e56335fbfe

		cpu: clean up architectural register classification

		Move from a poorly documented scheme where the mapping
		of unified architectural register indices to register
		classes is hardcoded all over to one where there's an
		enum for the register classes and a function that
		encapsulates the mapping.

Diff:

Revision 2 (+351 -109)

Show changes

	src/arch/arm/insts/misc.cc
	src/arch/arm/insts/static_inst.cc
	src/arch/power/insts/static_inst.cc
	src/arch/x86/insts/static_inst.cc
	src/cpu/SConscript
	src/cpu/reg_class.hh
	src/cpu/reg_class.cc
	src/cpu/checker/cpu_impl.hh
	5 more

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9844:7983be7501e7

Changeset 9846:76e56335fbfe

Diff:

Status: Closed (submitted)