cpu/o3: clean up physical register file

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9848:542532cc5b73
---------------------------
cpu/o3: clean up physical register file

No need for PhysRegFile to be a template class, or
have a pointer back to the CPU.  Also made some methods
for checking the physical register type (int vs. float)
based on the phys reg index, which will come in handy later.

Testing Done

Issue Summary

Description	From	Last Updated	Status
@return?	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
const	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
const	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
const	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
const	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
0 <=? Can it be negative?	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Dropped
const	Andreas Hansson	Aug. 26, 2013, 6:42 p.m.	Resolved
Is there a good reason these are not std::vectors? No need to change...just asking.	Andreas Hansson	Aug. 26, 2013, 6:43 p.m.	Dropped

LGTM

src/cpu/o3/regfile.hh (Diff revision 1)

@return?

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

const

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

const

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

const

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

const

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

0 <=? Can it be negative?

Show all issues

Steve Reinhardt Aug. 26, 2013, 6:45 p.m. (Aug. 26, 2013, 6:45 p.m.)

It's typedef'd to 'short int', so technically yes, but don't ask me why...

src/cpu/o3/regfile.hh (Diff revision 1)

const

Show all issues

src/cpu/o3/regfile.hh (Diff revision 1)

Is there a good reason these are not std::vectors? No need to change...just asking.

Show all issues

Steve Reinhardt Aug. 26, 2013, 6:45 p.m. (Aug. 26, 2013, 6:45 p.m.)

No good reason, just history... but similarly no great benefit to changing at this point either, IMO.

Description:

~		Changeset 9846:816e0d9e97a0
	~	Changeset 9848:b55ab0dc9abc

		cpu/o3: clean up physical register file

		No need for PhysRegFile to be a template class, or
		have a pointer back to the CPU. Also made some methods
		for checking the physical register type (int vs. float)
		based on the phys reg index, which will come in handy later.

Diff:

Revision 2 (+84 -70)

Show changes

	src/cpu/o3/cpu.cc
	src/cpu/o3/cpu_policy.hh
	src/cpu/o3/regfile.hh

Summary:

-	cpu/o3: clean up physical register file
+	cpu/o3: clean up scoreboard object

Description:

~		Changeset 9848:b55ab0dc9abc
	~	Changeset 9849:b2e43d792a9e

~		cpu/o3: clean up physical register file
	~	cpu/o3: clean up scoreboard object

~		No need for PhysRegFile to be a template class, or
~		have a pointer back to the CPU. Also made some methods
~		for checking the physical register type (int vs. float)
~		based on the phys reg index, which will come in handy later.
	~	It had a bunch of fields (and associated constructor
	~	parameters) thet it didn't really use, and the array
	~	initialization was needlessly verbose.
	~
	+	Also just hardwired the getReg() method to aleays
	+	return true for misc regs, rather than having an array
	+	of bits that we always kept marked as ready.

Diff:

Revision 3 (+113 -173)

Show changes

	src/cpu/o3/cpu.cc
	src/cpu/o3/regfile.hh
	src/cpu/o3/rename_impl.hh
	src/cpu/o3/scoreboard.hh
	src/cpu/o3/scoreboard.cc

Summary:

-	cpu/o3: clean up scoreboard object
+	cpu/o3: clean up physical register file

Description:

~		Changeset 9849:b2e43d792a9e
	~	Changeset 9848:542532cc5b73

~		cpu/o3: clean up scoreboard object
	~	cpu/o3: clean up physical register file

~		It had a bunch of fields (and associated constructor
~		parameters) thet it didn't really use, and the array
~		initialization was needlessly verbose.
~
	~	No need for PhysRegFile to be a template class, or
	~	have a pointer back to the CPU. Also made some methods
	~	for checking the physical register type (int vs. float)
	~	based on the phys reg index, which will come in handy later.
-		Also just hardwired the getReg() method to aleays
-		return true for misc regs, rather than having an array
-		of bits that we always kept marked as ready.

Diff:

Revision 4 (+88 -73)

Show changes

	src/cpu/o3/cpu.cc
	src/cpu/o3/cpu_policy.hh
	src/cpu/o3/regfile.hh

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9846:816e0d9e97a0

Changeset 9848:b55ab0dc9abc

Diff:

Summary:

Description:

Changeset 9848:b55ab0dc9abc

Changeset 9849:b2e43d792a9e

Diff:

Summary:

Description:

Changeset 9849:b2e43d792a9e

Changeset 9848:542532cc5b73

Diff:

Status: Closed (submitted)