cpu/o3: clean up scoreboard object
Review Request #1984 - Created Aug. 21, 2013 and submitted
| Information | |
|---|---|
| Steve Reinhardt | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9849:4109eae11e50 --------------------------- cpu/o3: clean up scoreboard object It had a bunch of fields (and associated constructor parameters) thet it didn't really use, and the array initialization was needlessly verbose. Also just hardwired the getReg() method to aleays return true for misc regs, rather than having an array of bits that we always kept marked as ready.
Posted (Aug. 22, 2013, 3:49 p.m.)
-
src/cpu/o3/scoreboard.hh (Diff revision 1) -
How did we ever get away without it?
-
src/cpu/o3/scoreboard.hh (Diff revision 1) -
unsigned?
-
src/cpu/o3/scoreboard.hh (Diff revision 1) -
unsigned?
-
src/cpu/o3/scoreboard.hh (Diff revision 1) -
const
-
src/cpu/o3/scoreboard.hh (Diff revision 1) -
const
-
src/cpu/o3/scoreboard.cc (Diff revision 1) -
Perhaps a bit orthogonal, but should this not be parent.name() + ".scoreboard", where it seems the parent name has to be passed in the constructor.
i do really appreciated changes where a lot of code goes away and the functionality stays the same
Review request changed
Updated (Aug. 26, 2013, 7:12 p.m.)
Description: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+106 -167) |
Ship It!