src/base/statistics.hh (Diff revision 1)

This should be default anyways, why is this needed?

Show all issues

1. Nilay Vaish Sept. 4, 2013, 11:09 a.m. (Sept. 4, 2013, 11:09 a.m.)

   I think the constructor: DataWrapVec(const DataWrapVec &ref)
   is not there by default. If I add this constructor, then the
   constructor DataWrapVec() also needs to be added.

2. Andreas Hansson Sept. 6, 2013, 2:43 a.m. (Sept. 6, 2013, 2:43 a.m.)

   The default copy constructor will do a shallow copy. I don't object to the explicit one, but I don't think it's needed.

src/mem/ruby/network/garnet/BaseGarnetNetwork.hh (Diff revision 1)

Could you add a doxy line describing what they are supposed to do?

Is any subclass actually doing anything with clearStats?

Show all issues

1. Nilay Vaish Sept. 4, 2013, 11:09 a.m. (Sept. 4, 2013, 11:09 a.m.)

   I am removing this function. The same functionality can be achieved by 
   using the resetStats() function of the SimObject class.

src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh (Diff revision 1)

const double return seems a bit excessive :-)

Show all issues

src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh (Diff revision 1)

const unsigned int returned for a good reason?

Show all issues

Seems like a great step in the right direction. Thanks Nilay!

No objections from my side, but I guess some Ruby user (Brad?) should also have a look.