kvm: Add x86 segment register verification to help debugging

Download Diff
View Diff

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9883:f9cf2f65359c
---------------------------
kvm: Add x86 segment register verification to help debugging

Testing Done

Expand All
Collapse All

src/cpu/kvm/x86_cpu.cc (Diff revision 1)

This function name is pretty ambiguous... how about isCanonicalSegBase()?

Andreas Sandberg Sept. 19, 2013, 1:10 a.m. (Sept. 19, 2013, 1:10 a.m.)

I'm renaming it to isCanonicalAddress() since it is more general than segment base addresses. I'm also adding a comment to explain what a canonical address is.

Description:

~		Changeset 9872:9328d4f007cb
	~	Changeset 9883:f9cf2f65359c

		kvm: Add x86 segment register verification to help debugging
-
-
-
-		This patch is a part of series of changes to add support for KVM on x86. See https://github.com/andysan/gem5/tree/kvm-x86 for the full series.

Diff:

Revision 2 (+162)

Show changes

src/cpu/kvm/x86_cpu.cc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 9872:9328d4f007cb

Changeset 9883:f9cf2f65359c

Diff:

Status: Closed (submitted)