kvm: Add support for thread-specific instruction events
Review Request #2017 - Created Sept. 19, 2013 and submitted
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9888:0bdbf5b24c62 --------------------------- kvm: Add support for thread-specific instruction events Instruction events are currently ignored when executing in KVM. This changeset adds support for triggering KVM exits based on instruction counts using hardware performance counters. Depending on the underlying performance counter implementation, there might be some inaccuracies due to instructions being counted in the host kernel when entering/exiting KVM. Due to limitations/bugs in Linux's performance counter interface, we can't reliably change the period of an overflow counter. We work around this issue by detaching and reattaching the counter if we need to reconfigure it.
Looks fine other than the comment. No need to post for re-review on my account, if you want to just add the comment and commit.
-
src/cpu/kvm/base.cc (Diff revision 1) -
A brief comment explaining the purpose of this function would be nice (esp. since the only usage I see is 1000 lines away).