ruby: eliminate non-determinism from ruby.stats output
Review Request #2028 - Created Sept. 27, 2013 and submitted
| Information | |
|---|---|
| Steve Reinhardt | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9896:dae3245884f3 --------------------------- ruby: eliminate non-determinism from ruby.stats output Get rid of non-deterministic "stats" in ruby.stats output such as time & date of run, elapsed & CPU time used, and memory usage. These values cause spurious miscomparisons when looking at output diffs (though they don't affect regressions, since the regressions pass/fail status currently ignores ruby.stats entirely). Most of this information is already captured in other places (time & date in stdout, elapsed time & mem usage in stats.txt), where the regression script is smart enough to filter it out. It seems easier to get rid of the redundant output rather than teaching the regression tester to ignore the same information in two different places.
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Is this comment still necessary? | Joel Hestness | Sept. 28, 2013, 7:14 p.m. | Open |
I've had a personal patch for a while that comments out the code you're eliminating here, and I sympathize with wanting to eliminate this to ease regression parsing. I've always wondered why we even print a version of this data to the stats.txt and not just a separate file for simulator-specific data (i.e. separate from simulated system statistics). That would completely eliminate the non-deterministic stats problem. Minor comment below, but otherwise, this looks good to me.
-
src/mem/ruby/profiler/Profiler.cc (Diff revision 1) -
Is this comment still necessary?
Ship It!