ruby: Simplify RubyPort flow control and routing

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10024:e4070f4c57f3
---------------------------
ruby: Simplify RubyPort flow control and routing

This patch simplfies the retry logic in the RubyPort, avoiding
redundant attributes, and enforcing more stringent checks on the
interactions with the normal ports. The patch also simplifies the
routing done by the RubyPort, using the port identifiers instead of a
heavy-weight sender state.

The patch also fixes a bug in the sending of responses from PIO
ports. Previously these responses bypassed the queue in the queued
port, and ignored the return value, potentially leading to response
packets being lost.

Testing Done

All regressions pass

Issue Summary

Description	From	Last Updated	Status
How do you know that the destination value is what it should be? Should not the packet be routed using ...	Nilay Vaish	Jan. 23, 2014, 12:23 a.m.	Dropped

src/mem/ruby/system/RubyPort.cc (Diff revision 1)

How do you know that the destination value is what it should be?  Should not
the packet be routed using the address in the packet?

Show all issues

Andreas Hansson Jan. 21, 2014, 1:38 a.m. (Jan. 21, 2014, 1:38 a.m.)

Responses should be routed on the dest field in the classic memory system. Any multiplexing component is responsible for setting the source when the request passes through. Only requests are routed based on address.

Moreover, any component that changes the src has to store the old value in a sender state and restore it later.

Ship It!

Description:

~		Changeset 9921:a05240033e7e
	~	Changeset 10024:e4070f4c57f3

		ruby: Simplify RubyPort flow control and routing

		This patch simplfies the retry logic in the RubyPort, avoiding
		redundant attributes, and enforcing more stringent checks on the
		interactions with the normal ports. The patch also simplifies the
		routing done by the RubyPort, using the port identifiers instead of a
		heavy-weight sender state.

		The patch also fixes a bug in the sending of responses from PIO
		ports. Previously these responses bypassed the queue in the queued
		port, and ignored the return value, potentially leading to response
		packets being lost.

Diff:

Revision 2 (+74 -98)

Show changes

	src/mem/qport.hh
	src/mem/ruby/system/RubyPort.hh
	src/mem/ruby/system/RubyPort.cc
	src/mem/ruby/system/Sequencer.cc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9921:a05240033e7e

Changeset 10024:e4070f4c57f3

Diff:

Status: Closed (submitted)