Review Board 2.0.15


X86: Make the x86 ExtMachInst serializable with (UN)SERIALIZE_SCALAR.

Review Request #209 - Created Aug. 22, 2010 and submitted

Information
Gabe Black
gem5
Reviewers
Default 
X86: Make the x86 ExtMachInst serializable with (UN)SERIALIZE_SCALAR.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Nathan Binkert

   
Posted  (Aug. 23, 2010, 12:03 a.m.)


  


  


  

   



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Actually, can you use (UN)SERIALIZE_SCALAR?  The commit message says that you can, but then you never use it.
    
    
    
   
    2. 

   


  




   







    

     
     

      

       
        

         
          src/arch/x86/types.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Do you really need to include this here, or can you just include it in the .cc file?  Perhaps because of the template <>, you do need to include it here.  In general, I'd like to support overloading paramIn and paramOut better and have this be the general mechanism for serializing sub-objects.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I have a patch that converts setInst and getInst and the backing storage to ExtMachInst which uses it, but I'm going to try passing the StaticInst to the fault's invoke like Steve suggested to get rid of setInst and getInst entirely. This still seemed useful, though, so I left it in. I think you'd get an error about paramIn and paramOut not being templates if you don't have that include.
    
    
    
   
    2.