ext: Add a McPAT regression tester
Review Request #2118 - Created Dec. 11, 2013 and submitted
| Information | |
|---|---|
| Yasuko Eckert | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9998:a65b5406ecdc --------------------------- ext: Add a McPAT regression tester Add a regression tester to McPAT. Joel Hestness wrote these tests and Yasuko Eckert modified them to reflect the new McPAT interface and other changes the previous patch #2117 made. The McPAT output data have been correlated to an AMD CPU core model, which includes an out-of-order core and L1 caches. However, some of the changes made during the correlation effort have AMD proprietary information and hence, are not included in this patch or the previous one #2117.
Posted (Dec. 14, 2013, 12:19 p.m.)
From my side, mostly just minor requested changes below. There are a couple other things that would be nice to change (like my use of regexes, some of which make me cringe realizing I once wrote them :P), but it's probably not necessary to address them at this time. The only big request that I have here is that it would be nice to have some indication about whether/how the McPAT output data has been validated. It's been a long time since I've validated any data, and it would be hard for me to check the McPAT changes since then to see how the outputs may have changed. Can you add some notes on this to the commit message?
-
ext/mcpat/regression/regression.py (Diff revision 1) -
Minor: Can you add a little more detail here? In particular: "This tester can compile and runs McPAT on the input contained in the specified directory, and then compares the output to that of a prior run in order to ensure that specific power and area calculations do not change."
-
ext/mcpat/regression/regression.py (Diff revision 1) -
Minor: Can you please use my current email address (hestness@cs.wisc.edu) in each of these files?
-
ext/mcpat/regression/regression.py (Diff revision 1) -
Minor: Should this comment actually indicate that this is where we run McPAT on the input?
-
ext/mcpat/regression/test-0/power_region0.xml (Diff revision 1) -
Minor: Can you please tweak these files to use consistent tabs or spaces, and hierarchical indentation to make them easier to read?
Review request changed
Updated (Dec. 16, 2013, 1:23 p.m.)
Change Summary:
Addressed all the concerns Joel raised.
Description: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+6568) |
Thanks for the changes! Looks good to me.
Posted (Jan. 21, 2014, 11:40 a.m.)
Overall, the files look good, but unless I missed it, I do not see any documentation associated with these tests. Please add a short README to this patch. Also add a twiki page to gem5.org on how the McPAT flow works. Thanks!
Review request changed
Updated (Jan. 22, 2014, 4:53 p.m.)
Change Summary:
Added a README as requested by Brad.
Description: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+6644) |