Review Board 2.0.15


X86: Create a directory for files that define register indexes.

Review Request #215 - Created Aug. 22, 2010 and submitted

Information
Gabe Black
gem5
Reviewers
Default 
X86: Create a directory for files that define register indexes.

This is to help tidy up arch/x86. These files should not be used external to
the ISA.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Nathan Binkert

   
Posted  (Aug. 23, 2010, 12:12 a.m.)


  


  


  

   
In reviewboard, it just looks like you deleted a bunch of stuff, though I guess you actually did an "hg mv"?



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Yeah. In the patch itself those files all say something like this.

diff --git a/src/arch/x86/apicregs.hh b/src/arch/x86/regs/apic.hh
rename from src/arch/x86/apicregs.hh
rename to src/arch/x86/regs/apic.hh

Apparently either reviewboard or the reviewboard extension didn't understand that, or I didn't pass in the right magic option.
    
    
    
   
    2.