ext: Redirect McPAT object files
Review Request #2151 - Created Jan. 21, 2014 and submitted
| Information | |
|---|---|
| Yasuko Eckert | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9995:9d1f9c84c475 --------------------------- ext: Redirect McPAT object files All object files and McPAT binaries are moved to directory gem5/build/mcpat/ rather than creating them locally.
Review request changed
Updated (Jan. 21, 2014, 5:35 p.m.)
Summary: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||
Diff: |
Revision 2 (+19 -21) |
Posted (Jan. 21, 2014, 6:41 p.m.)
Looks good to me... just the one minor change below and I'm fine. I'm assuming mcpat is typically built separately from gem5? If not, and if we wanted to be fancy, we could put a rule in the SConstruct file that invokes make, passing in the proper value for BUILD_DIR... but that seems cute but unnecessary to me.
-
ext/mcpat/makefile (Diff revision 2) -
Someone might be using an alternate build directory, so it would be good to let them override that from the command line. You could do this: BUILD_DIR ?= ../../build ODIR = $(BUILD_DIR)/mcpat
Review request changed
Updated (Jan. 21, 2014, 10:07 p.m.)
Change Summary:
Thank you for the great suggestion, Steve! I added the BUILD_DIR variable in the makefile. McPAT is built separately from gem5, so we cannot use the SConstruct to invoke McPAT's make.
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+20 -21) |
Ship It!
Posted (Jan. 22, 2014, 12:57 a.m.)
-
ext/mcpat/makefile (Diff revision 3) -
What about all? Also, there seems to be no depend target
-
ext/mcpat/mcpat.mk (Diff revision 3) -
$^ instead of $(OBJS)?
Review request changed
Updated (Jan. 22, 2014, 4:27 p.m.)
Change Summary:
Addressed all the issues raised by Andreas.
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+22 -23) |