Review Board 2.0.15


CPU: Set a default value when readBytes faults.

Review Request #216 - Created Aug. 22, 2010 and submitted

Information
Gabe Black
gem5
Reviewers
Default 
CPU: Set a default value when readBytes faults.

This was being done in read(), but if readBytes was called directly it
wouldn't happen. Also, instead of setting the memory blob being read to -1
which would (I believe) require using memset with -1 as a parameter, this now
uses bzero. It's hoped that it's more specialized behavior will make it
slightly faster.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Nathan Binkert

   
Posted  (Aug. 23, 2010, 12:18 a.m.)


  


  


  

   
memset and bzero are the same thing.  I'd personally rather even see some thing like 0xAA in the memset so that we can see what happened.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I've been told this was accidentally already committed, so I'll just replace bzero with memset(0xaa).
    
    
    
   
    2.