dev: Include basic devices in NULL ISA build

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10065:64aecee7d755
---------------------------
dev: Include basic devices in NULL ISA build

This patch enbles use of the basic PIO devices as part of the NULL
build. Although it might seem counter intuitive to have a PIO device
without being able to execute a driver, this change enables us to
break a device class hierarchy into an ISA-agnostic part, and an
ISA-specific part, without requiring multiple-inheritance. The
ISA-agnostic base class is a PIO device, but does not make use of the
port.

Testing Done

All regressions pass

I don't follow your rationale, but I don't see any harm in what you're doing either... but I think you're doing it awkwardly ;-).

src/dev/SConscript (Diff revision 1)

If you want these files to be compiled in unconditionally, why not just list them once above the if instead of listing them twice?

Description:

~		Changeset 10065:573eff8aee0c
	~	Changeset 10065:64aecee7d755

		dev: Include basic devices in NULL ISA build

		This patch enbles use of the basic PIO devices as part of the NULL
		build. Although it might seem counter intuitive to have a PIO device
		without being able to execute a driver, this change enables us to
		break a device class hierarchy into an ISA-agnostic part, and an
		ISA-specific part, without requiring multiple-inheritance. The
		ISA-agnostic base class is a PIO device, but does not make use of the
		port.

Diff:

Revision 2 (+5 -8)

Show changes

	src/dev/SConscript
	src/dev/baddev.cc

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 10065:573eff8aee0c

Changeset 10065:64aecee7d755

Diff:

Status: Closed (submitted)