mem: Edit proto Packet and enhance the python script

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10097:b626fd659b6a
---------------------------
mem: Edit proto Packet and enhance the python script

This patch changes the decode script to output the optional fields of
the proto message Packet, namely id and flags. The flags field is set
by the communication monitor.

The id field is useful for CPU trace experiments, e.g. linking the
fetch side to decode side. It had to be renamed because it clashes
with a built in python function id() for getting the "identity" of an
object.

This patch also takes a few common function definitions out from the
multiple scripts and adds them to a protolib python module.

Testing Done

All regressions pass. Note that we have _not_ updated the version
number (given that this field was optional, and most likely not
widely used).

Issue Summary

Description	From	Last Updated	Status
Andreas, can you explain the need for Google's copyright notice?	Nilay Vaish	Feb. 25, 2014, 10:51 a.m.	Resolved
The encode and decode are google's implementations straight from the protobuf source.	Andreas Hansson	Feb. 25, 2014, 10:51 a.m.	Resolved
Where possible, it's nice to keep the copyrights separate. If you've directly lifted google code, can you put that code ...	Nathan Binkert	Feb. 26, 2014, 2:36 a.m.	Resolved

util/protolib.py (Diff revision 1)

Andreas, can you explain the need for Google's copyright notice?

Show all issues

util/protolib.py (Diff revision 1)

The encode and decode are google's implementations straight from the protobuf source.

Show all issues

Ship It!

util/protolib.py (Diff revision 1)

Where possible, it's nice to keep the copyrights separate.  If you've directly lifted google code, can you put that code in a separate file?  If not, no big deal, it's just nice to be able to drop a license when the original code is no longer used.

Show all issues

Andreas Hansson Feb. 25, 2014, 10:54 a.m. (Feb. 25, 2014, 10:54 a.m.)

Good point. I'd say let's keep protolib.py as it is (both Google and ARM copyright). The Google copyright can be removed from the encode and decode scripts though. I'll repost the patch.

Description:

~		Changeset 10079:1b871a9a8277
	~	Changeset 10097:b626fd659b6a

		mem: Edit proto Packet and enhance the python script

		This patch changes the decode script to output the optional fields of
		the proto message Packet, namely id and flags. The flags field is set
		by the communication monitor.

		The id field is useful for CPU trace experiments, e.g. linking the
		fetch side to decode side. It had to be renamed because it clashes
		with a built in python function id() for getting the "identity" of an
		object.

		This patch also takes a few common function definitions out from the
		multiple scripts and adds them to a protolib python module.

Diff:

Revision 2 (+154 -140)

Show changes

	src/proto/packet.proto
	util/decode_packet_trace.py
	util/encode_packet_trace.py
	util/protolib.py

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10079:1b871a9a8277

Changeset 10097:b626fd659b6a

Diff:

Status: Closed (submitted)