ruby: cluster topology config fix

Information
Submitter:	Malek Musleh
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10158:97c7a8d9ea1e
---------------------------
ruby: cluster topology config fix

This patch adds a missing member function, and updates the ruby config file to include the list of controllers for the Cluster topology. Previously the list of controllers was not being passed to the topology.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Can you explain the reason for this change in more detail? The way we use this topology (in gem5-gpu) is ...	Jason Lowe-Power	April 14, 2014, 8:14 p.m.	Resolved
I am not in favour of adding such ad hoc checks to the config file.	Nilay Vaish	April 10, 2014, 9:58 a.m.	Open

configs/topologies/Cluster.py (Diff revision 1)

Can you explain the reason for this change in more detail?

The way we use this topology (in gem5-gpu) is like this:

gpu_cluster = Cluster()
for i in xrange(number of CUs):
  ...
  gpu_cluster.add(l1_cntrl)

And similarly for the CPU cluster.

At a minimum, could you change this so that controllers defaults to the empty list? This way current code which uses the cluster topology will still work.

Show all issues

Summary:

-	ruby: cluster config fix _init_ + and missing fuc
+	ruby: cluster topology config fix

Description:

~		Changeset 10158:6e2ebdf2e286
	~	Changeset 10158:97c7a8d9ea1e

		ruby: cluster topology config fix
	+
	+	This patch adds a missing member function, and updates the ruby config file to include the list of controllers for the Cluster topology. Previously the list of controllers was not being passed to the topology.

Diff:

Revision 2 (+5 -1)

Show changes

	configs/ruby/Ruby.py
	configs/topologies/Cluster.py
	src/mem/ruby/slicc_interface/AbstractController.hh

Ship It!

Ship It!

configs/ruby/Ruby.py (Diff revision 2)

I am not in favour of adding such ad hoc checks to the config file.

Show all issues

Malek Musleh April 14, 2014, 8:13 p.m. (April 14, 2014, 8:13 p.m.)

I am not quite sure what you mean. There are other instances in the config scripts where string comparisons are done, so there is a long precedent for that (including a patch that was recently committed). Do you prefer doing something like if type(topology) == Cluster? If so, I tried that initially, but it required adding additional imports to the top of Ruby.py, and created some other complications that prevents it from running.

Jason Lowe-Power April 21, 2014, 7:06 a.m. (April 21, 2014, 7:06 a.m.)

I think a solution is to go back to your first diff and change the line in Cluster.py to:
__init__(self, controllers=[],...

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Issue Summary

Summary:

Description:

Changeset 10158:6e2ebdf2e286

Changeset 10158:97c7a8d9ea1e

Diff: