ARM: fixed a bug in the arm register flattening logic (FP_Base_DepTag was set too low)
Review Request #227 - Created Aug. 23, 2010 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| Reviewers | |
| Default | |
ARM: fixed a bug in the arm register flattening logic (FP_Base_DepTag was set too low) when decoding a srs instruction, invalid mode encoding returns invalid instruction. this can happen when garbage instructions are fetched from mispredicted path
Posted (Aug. 23, 2010, 4:29 a.m.)
You're commit message needs reformatting. The first line is much too long.
-
src/arch/arm/registers.hh (Diff revision 1) -
Lets avoid trivial whitespace changes mixed in with other stuff. Please make this a separate change.
-
src/arch/arm/registers.hh (Diff revision 1) -
Why was this added? I'm mostly just curious. Did something depend on it? I don't like the idea of constants trivially and consistently derived from other constants being defined in all the ISAs, but it's probably not worth doing anything about it here.