Review Board 2.0.15


style: eliminate equality tests with true and false

Review Request #2281 - Created May 31, 2014 and submitted

Information
Steve Reinhardt
gem5
default
Reviewers
Default
Changeset 10231:df1b95c06e38
---------------------------
style: eliminate equality tests with true and false

Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.

It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.

Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.

   
Review request changed
Updated (June 4, 2014, 7:49 a.m.)

Status: Closed (submitted)