mem: Properly set cache block status fields on writebacks
Review Request #2291 - Created June 12, 2014 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10239:af942fe9d30b --------------------------- mem: Properly set cache block status fields on writebacks When a cacheline is written back to a lower-level cache, tags->insertBlock() sets various status parameters. However these status bits were cleared immediately after calling. This patch makes it so that these status fields are not cleared.
Posted (June 19, 2014, 7:33 p.m.)
I see you're talking about the 'secure' flag... wouldn't it make more sense to set the secure flag in cache_impl.hh and not in tags? That's what's done in handleFill() (where the secure bit is set a second time in handleFill() after already being set in tags->insertBlock()). Originally the point of the separate tags class was to allow for pluggable replacement policies, and I'd think you'd want the secure stuff to be orthogonal to that.
Posted (Jan. 5, 2015, 3:29 p.m.)
I guess this is fixed, given the check for isSecure currently found in cache_impl.hh?