base: fix some bugs in EthAddr

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10250:177ddbf6d5cd
---------------------------
base: fix some bugs in EthAddr

per the IEEE 802 spec:
1) fixed broadcast() to ensure that all bytes are equal to 0xff.
2) fixed unicast() to ensure that bit 0 of the first byte is equal to 0
3) fixed multicast() to ensure that bit 0 of the first byte is equal to 1, and
   that it is not a broadcast.

also the constructors in EthAddr are fixed so that all bytes of data are
initialized.

Testing Done

Ship It!

src/base/inet.hh (Diff revision 1)

seems like it would be more consistent with the other code to do a loop up to ETH_ADDR_LEN, but this works too.

Tony Gutierrez July 2, 2014, 8:52 a.m. (July 2, 2014, 8:52 a.m.)
```
fixed
```

Description:

~		Changeset 10243:f30073e2cb22
	~	Changeset 10250:177ddbf6d5cd

		base: fix some bugs in EthAddr

		per the IEEE 802 spec:
		1) fixed broadcast() to ensure that all bytes are equal to 0xff.
		2) fixed unicast() to ensure that bit 0 of the first byte is equal to 0
		3) fixed multicast() to ensure that bit 0 of the first byte is equal to 1, and
		that it is not a broadcast.

		also the constructors in EthAddr are fixed so that all bytes of data are
		initialized.

Diff:

Revision 2 (+16 -5)

Show changes

	src/base/inet.hh
	src/base/inet.cc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 10243:f30073e2cb22

Changeset 10250:177ddbf6d5cd

Diff:

Status: Closed (submitted)