Review Board 2.0.15


syscall emulation: fix DPRINTF arg ordering bug

Review Request #2306 - Created July 3, 2014 and submitted - Latest diff uploaded

Information
Steve Reinhardt
gem5
default
Reviewers
Default
Changeset 10252:62ffe6aa9285
---------------------------
syscall emulation: fix DPRINTF arg ordering bug

When we switched getSyscallArg() from explicit arg indices to
the implicit method, some DPRINTF arguments were left as calls
to getSyscallArg(), even though C/C++ doesn't guarantee
anything about the order of invocation of these calls.  As a
result, the args could be printed out in arbitrary orders.

Interestingly, this bug has been around since 2009:
http://repo.gem5.org/gem5/rev/4842482e1bd1