config, x86: swap bus_id of ISA/PCI in X86 IntelMPTable
Review Request #2314 - Created July 16, 2014 and submitted
| Information | |
|---|---|
| Jiuyue Ma | |
| gem5 | |
| 2301 | |
| Reviewers | |
| Default | |
config, x86: swap bus_id of ISA/PCI in X86 IntelMPTable This patch assign bus_id=0 to PCI bus and bus_id=1 to ISA bus for X86 platform. Because PCI device get config space address using Pc::calcPciConfigAddr() which requires "assert(bus==0)". This fixes PCI interrupt routing and discovery on Linux.
Thanks for taking the time to fix this! This looks good, I'm happy to have this committed. I'd suggest that you add a line to the commit message saying that this fixes PCI interrupt routing and discovery on Linux.
Review request changed
Updated (July 17, 2014, 3:11 a.m.)
Change Summary:
change summary line add "this fixes PCI interrupt routing and discovery on Linux" to commit message
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Diff: |
Revision 2 (+11 -8) |
I assume this changes the X86 FS regressions? If so, I've got some more bus-related patches that we could bundle it up with.