SegInit, x86: Segment initialization to support KvmCPU in SE
Review Request #2322 - Created Aug. 1, 2014 and submitted
| Information | |
|---|---|
| Alexandru Dutu | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10302:8bbfa3e4752c --------------------------- SegInit, x86: Segment initialization to support KvmCPU in SE This patch sets up low and high privilege code and data segments and places them in the following order: cs low, ds low, ds, cs, in the GDT. Additionally, a syscall and page fault handler for KvmCPU in SE mode are defined. The order of the segment selectors in GDT is required in this manner for interrupt handling to work properly. Segment initialization is done for all the thread contexts.
Quick regression tests
-
src/sim/process.hh (Diff revision 1) -
Style issue: Member variables should not start with initial caps. Rename to kvmInSE or useKvmInSE.
Looks good other than the style issue above. As far as I'm concerned, you don't need to re-post after fixing that.
Review request changed
Updated (Sept. 16, 2014, 8:37 a.m.)
Change Summary:
Updated syscall and page fault handler. I am reposting this mainly for people to see how changes in http://reviews.gem5.org/r/2313/ are affecting this patch.
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+504 -94) |
Ship It!
