CPU: Print out traces for faluting instructions when the flag for it (ExecFaulting) is set

Information
Submitter:	Ali Saidi
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

CPU: Print out traces for faluting instructions when the flag for it (ExecFaulting) is set

Testing Done

src/cpu/simple/atomic.cc (Diff revision 1)

How about moving this check up to the surrounding if?

else if (traceData && !DTRACE(ExecFaulting)) {

That would fit into the flow of the code better, I think.

src/cpu/simple/atomic.cc (Diff revision 1)

Well, the code needs to delete trace data and set it to null either way. Only if the execfaulting flag is set does it need to dump()

Gabe Black Aug. 23, 2010, 4:18 a.m. (Aug. 23, 2010, 4:18 a.m.)

It will be later like it would have been with no fault in postExecute. I added that blob of code is to suppress dumping later if there was a fault, so everything will work fine if you suppress the suppressor and make it work like it temporarily work like it did before I added that. By making it dump here, you're making it do the same thing in two different places depending on the circumstances which might be confusing later on.

Ali Saidi Aug. 23, 2010, 4:23 a.m. (Aug. 23, 2010, 4:23 a.m.)
```
ok.
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files